Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(up): solution serialization sometime failed in the presence of non-symbolic parameters #141

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

arbimo
Copy link
Member

@arbimo arbimo commented Jul 11, 2024

fix #140

@arbimo
Copy link
Member Author

arbimo commented Jul 11, 2024

@nicola-gigante It seems that the CI now fails with the same error you encountered recently. Any hint on how to fix this?

My suspicion is that a new deployment to PIP was not backward compatible, and breaks the default installation (as UP does not impose strict version numbers on its dependencies).

@nicola-gigante
Copy link

Hi @arbimo, the fix was to remove numpy 2.0 and install any version of the 1.x line, because the incompatibility is between some package and numpy 2.x. In my project I just added numpy<2 in requirements.txt, I'm not sure what to do here precisely.

@arbimo arbimo merged commit 615dce8 into master Jul 11, 2024
10 checks passed
@arbimo arbimo deleted the non-sym-params branch July 11, 2024 11:21
@arbimo
Copy link
Member Author

arbimo commented Jul 11, 2024

Yep, requesting numpy < 2 on top of the UP requirements worked. Thanks for the tip, these two hours of yours were not completely wasted ;)

I have opened a PR on unified-planning to add this workaround upstream as well: aiplan4eu/unified-planning#617

The fix should be available in the development build now.

@nicola-gigante
Copy link

I'm glad it was time well spent 🤣 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behavior in scheduling problems with activities parameters (UP)
2 participants