-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watch launch problem in generated project #100
Conversation
@@ -32,9 +32,5 @@ | |||
</dict> | |||
<key>WKExtensionDelegateClassName</key> | |||
<string>$(PRODUCT_MODULE_NAME).ExtensionDelegate</string> | |||
<key>UIRequiredDeviceCapabilities</key> | |||
<array> | |||
<string>arm64</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the culprit. Others are clean-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Since this is running on the phone it’s confusing why it would break...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simulator isn't arm64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I recall we had to add this somewhere in order to upload the App Store. Hopefully it was just necessary for the main app and not this extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @qyang-nj
<key>DTPlatformName</key> | ||
<string>watchsimulator</string> | ||
<key>DTSDKName</key> | ||
<string>watchsimulator2.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my limit observation, DT prefix indicates they are internal Xcode settings, which are usually inserted by Xcode automatically. Unlike other keys, those DT keys don't have any official doc to explain them.
@@ -32,9 +32,5 @@ | |||
</dict> | |||
<key>WKExtensionDelegateClassName</key> | |||
<string>$(PRODUCT_MODULE_NAME).ExtensionDelegate</string> | |||
<key>UIRequiredDeviceCapabilities</key> | |||
<array> | |||
<string>arm64</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Since this is running on the phone it’s confusing why it would break...
make project
)make debug
)Fix issue #97.
@bachand