Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watch launch problem in generated project #100

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

qyang-nj
Copy link
Collaborator

  • Built and ran in Xcode (make project)
  • Built and ran with Buck CLI (make debug)

Fix issue #97.

@bachand

@qyang-nj qyang-nj changed the title Fix watch on simulator Fix watch launch problem in generated project Apr 29, 2019
@@ -32,9 +32,5 @@
</dict>
<key>WKExtensionDelegateClassName</key>
<string>$(PRODUCT_MODULE_NAME).ExtensionDelegate</string>
<key>UIRequiredDeviceCapabilities</key>
<array>
<string>arm64</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the culprit. Others are clean-up.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Since this is running on the phone it’s confusing why it would break...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator isn't arm64.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I recall we had to add this somewhere in order to upload the App Store. Hopefully it was just necessary for the main app and not this extension.

Copy link
Collaborator

@dfed dfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@bachand bachand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qyang-nj

<key>DTPlatformName</key>
<string>watchsimulator</string>
<key>DTSDKName</key>
<string>watchsimulator2.0</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these not necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my limit observation, DT prefix indicates they are internal Xcode settings, which are usually inserted by Xcode automatically. Unlike other keys, those DT keys don't have any official doc to explain them.

@@ -32,9 +32,5 @@
</dict>
<key>WKExtensionDelegateClassName</key>
<string>$(PRODUCT_MODULE_NAME).ExtensionDelegate</string>
<key>UIRequiredDeviceCapabilities</key>
<array>
<string>arm64</string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Since this is running on the phone it’s confusing why it would break...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants