Consolidate on en for development language
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qyang-nj
approved these changes
May 1, 2019
| @@ -53,7 +55,7 @@ def library_configs(): | |||
| def app_binary_configs(name): | |||
| binary_specific_config = { | |||
| "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES": "YES", | |||
| "DEVELOPMENT_LANGUAGE": "Swift", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is the root cause problem of #101.
Right now we are setting this to
en-usin some places andSwiftin other 馃う鈥嶁檪In a standard Xcode project, this defaults to
en. Apple suggested I set it toen.In our production app, we are inconsistent. In one target we have it as
English(which is invalid). In two others I checked we have it asen.It feels inelegant setting a global variable, but this also feels like a step in the right direction of being more DRY.
Thank you Apple for your help, if you're watching 馃槃
I'm leaving that issue open until I rebase my other branch.
make project)make debug)cc: @qyang-nj @dfed