-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of https://bugs.swift.org/browse/SR-6004, and instructions on how to work around it #38
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
44f1ce0
add example of https://bugs.swift.org/browse/SR-6004
bachand 91eadaf
Improvements
bachand b82d772
Improvements
bachand be6e9bf
Move MyFactory to right place
bachand c2fce21
Commnets
bachand 1fc418e
Documentation
bachand a588f9e
Comment
bachand 89d234b
More
bachand a7ee6a3
Fix comments
bachand 6a94587
Comment
bachand 818626a
Remove @objc added by accdient
bachand e1ea6a0
Comment
bachand 78fa670
Merge branch 'master' into mb--add-protocol-issue
dfed bb6852d
Merge branch 'master' into mb--add-protocol-issue
bachand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
Libraries/Swift3/Sources/MyPublicClass+MyPublicProtocol.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// | ||
// MyPublicClass+MySecondPublicProtocol.swift | ||
// Swift3 | ||
// | ||
// Created by Michael Bachand on 2/6/19. | ||
// | ||
|
||
import Foundation | ||
import Swift4 | ||
|
||
extension MyPublicClass: MyPublicProtocol { | ||
public var currrentThought: String { | ||
return "This should be visible in the main module!" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// | ||
// MySecondPublicProtocol.swift | ||
// Swift3 | ||
// | ||
// Created by Michael Bachand on 2/6/19. | ||
// | ||
|
||
import Foundation | ||
|
||
public protocol MyPublicProtocol { | ||
var currrentThought: String { get } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// | ||
// MyFactory.swift | ||
// Swift4 | ||
// | ||
// Created by Michael Bachand on 2/6/19. | ||
// | ||
|
||
import Foundation | ||
|
||
public class MyFactory { | ||
/// Returns a type-erased instance of `MyPublicClass`. | ||
public static func myPublicObject() -> Any { | ||
return MyPublicClass() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// | ||
// MyPublicClass.swift | ||
// Swift4 | ||
// | ||
// Created by Michael Bachand on 2/6/19. | ||
// | ||
|
||
import Foundation | ||
|
||
public final class MyPublicClass { | ||
public init() { } | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth writing the above as a unit test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea. I'm gonna leave as-is for now but something to think about down the road. 🤞 Apple fixes this soon since it's affecting both Airbnb and Lyft (and this presumably other big companies as well!)