Expose URI that was deeplinked through a parameter #10
Conversation
|
Addresses #7 |
|
I'd like to see a test around this change to guarantee that the generated intent has this new key in the bundle. Please let me know if you need directions on how to do it |
| @@ -187,6 +187,7 @@ private void generateDeepLinkActivity() throws IOException { | |||
| .endControlFlow() | |||
| .addStatement("parameterMap.put(queryParameter, uri.getQueryParameter(queryParameter))") | |||
| .endControlFlow() | |||
| .addStatement("parameterMap.put(DeepLink.URI, hostPath)") | |||
There was a problem hiding this comment.
We should have an intact URI with the scheme, so we should replace hostPath with uri.toString().
|
@felipecsl Yeah, if you could give me some pointers on how I could test this, I'd gladly write some or it. I wanted to submit one, but I wasn't sure how best to test that. |
|
@MichaelEvans looks like none of the existing test are suitable to cover this test scenario. I'll set up some Robolectric tests that will make this easier. Hang tight! |
MichaelEvans
force-pushed
the
expose_uri
branch
2 times, most recently
from
bc69b2b
to
79b6543
Compare
Update intent tests to check URI param
|
@felipecsl added some assertions to the tests from #11 to verify the behavior |
|
⛵ |
Expose URI that was deeplinked through a parameter
|
yay! thanks @MichaelEvans |
|
woot! thanks! |
No description provided.