Issue-221 Skip categories screen in case of having only components #222
Conversation
themanol
commented
Feb 15, 2022
themanol
commented
|
What do you think about passing this option as a flag in the showkase activity intent? @vinaygaba @themanol |
|
@vinaygaba @themanol Do you think the suggestion above makes sense? |
|
@themanol I've somehow missed seeing this PR. Truly apologize for that. I'm ready to merge it once the builds pass. |
The build pass, we need a review here, Thanks! @vinaygaba |
|
Yes, looks like can be merged now. Would be great to have a new release with this. |
@marcorighini I think it probably makes sense to have this as the default behavior instead of making it configurable. If a lot of people think making it configurable is valuable, I'm open to reconsidering it. |
| NavHost( | ||
| navController = navController, | ||
| startDestination = ShowkaseCurrentScreen.SHOWKASE_CATEGORIES.name | ||
| ) { | ||
| startDestination = if (isOnlyComponents) { |
There was a problem hiding this comment.
I think we should make this generic i.e directly jump to the respective groups screen if only one type of elements are present.
For example, if there are only colors, it should directly go to the colors groups screen. Same with typography or any other element that we might add support for in the future.
There was a problem hiding this comment.
ok, it makes sense, I can change this to be the default behaviour
showkase/src/main/java/com/airbnb/android/showkase/ui/ShowkaseBrowserApp.kt
Outdated
Show resolved
Hide resolved
showkase/src/main/java/com/airbnb/android/showkase/ui/ShowkaseCategoriesScreen.kt
Outdated
Show resolved
Hide resolved
showkase/src/main/java/com/airbnb/android/showkase/ui/ShowkaseCategoriesScreen.kt
Outdated
Show resolved
Hide resolved
