Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades terraform modules to Terraform 0.12.9 #156

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Upgrades terraform modules to Terraform 0.12.9 #156

merged 1 commit into from
Jan 23, 2020

Conversation

Ryxias
Copy link
Contributor

@Ryxias Ryxias commented Jan 22, 2020

to: @airbnb/binaryalert-maintainers
size: medium

Changes

  • Upgrades Terraform syntax on all modules to 0.12
  • Upgrades pyhcl to 0.4.0 to be Terraform 0.12 compatible

Testing

I sync'd internally and tested a terraform plan, which works.... with some tweaking.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.52% when pulling 08ca210 on dw--tf012 into 3877787 on master.

blakemotl
blakemotl approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@blakemotl blakemotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ryxias Ryxias merged commit a9c0f06 into master Jan 23, 2020
@Ryxias Ryxias deleted the dw--tf012 branch January 23, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakemotl blakemotl blakemotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryxias @coveralls @blakemotl