[bugfix] slice description makes charts overflow (#993) (#1010)

apache · Aug 26, 2016 · 7eceb14 · 7eceb14
1 parent b93f9ec
commit 7eceb14
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 9 deletions.
diff --git a/caravel/assets/javascripts/explore/components/QueryAndSaveBtns.jsx b/caravel/assets/javascripts/explore/components/QueryAndSaveBtns.jsx
@@ -14,15 +14,15 @@ export default function QueryAndSaveBtns({ canAdd, onQuery }) {
   return (
     <div className="btn-group query-and-save">
       <button type="button" className="btn btn-primary btn-sm" onClick={onQuery}>
-        <i className="fa fa-bolt"></i>Query
+        <i className="fa fa-bolt"></i> Query
       </button>
       <button
         type="button"
         className={saveClasses}
         data-target="#save_modal"
         data-toggle="modal"
       >
-        <i className="fa fa-plus-circle"></i>Save as
+        <i className="fa fa-plus-circle"></i> Save as
       </button>
     </div>
   );

diff --git a/caravel/assets/javascripts/modules/caravel.js b/caravel/assets/javascripts/modules/caravel.js
@@ -153,8 +153,8 @@ const px = function () {
         if (data !== undefined) {
           $('#query_container').html(data.query);
         }
-        $('#timer').removeClass('btn-warning');
-        $('#timer').addClass('btn-success');
+        $('#timer').removeClass('label-warning label-danger');
+        $('#timer').addClass('label-success');
         $('span.view_query').removeClass('disabled');
         $('#json').click(function () {
           window.location = data.json_endpoint;
@@ -231,8 +231,8 @@ const px = function () {
         container.css('height', this.height());
         dttm = 0;
         timer = setInterval(stopwatch, 10);
-        $('#timer').removeClass('btn-danger btn-success');
-        $('#timer').addClass('btn-warning');
+        $('#timer').removeClass('label-danger label-success');
+        $('#timer').addClass('label-warning');
         this.viz.render();
       },
       resize() {

diff --git a/caravel/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx b/caravel/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
@@ -28,8 +28,8 @@ describe('QueryAndSaveButtons', () => {
     });
 
     it('renders buttons with correct text', () => {
-      expect(wrapper.find('button').contains('Query')).to.eql(true);
-      expect(wrapper.find('button').contains('Save as')).to.eql(true);
+      expect(wrapper.find('button').contains(' Query')).to.eql(true);
+      expect(wrapper.find('button').contains(' Save as')).to.eql(true);
     });
   });
 });
diff --git a/caravel/templates/caravel/explore.html b/caravel/templates/caravel/explore.html
@@ -192,9 +192,16 @@
                 </div>
                 <div class="col-md-6">
                   <div class="slice-meta-controls pull-right">
-                    <span id="is_cached" class="label label-default" title="{{ _("Force refresh" )}}" data-toggle="tooltip">
+                    <span id="is_cached" class="label label-default m-r-3" title="{{ _("Force refresh" )}}" data-toggle="tooltip">
                       cached
                     </span>
+                    <span
+                      class="label label-warning m-r-3"
+                      id="timer"
+                      title="{{ _("Query timer") }}"
+                      data-toggle="tooltip">
+                      {{ _("0 sec") }}
+                    </span>
                     <div class="btn-group results" role="group">
                       <a role="button" tabindex="0" class="btn btn-default btn-sm" id="shortner" data-toggle="popover" data-trigger="focus">
                         <i class="fa fa-link" data-toggle="tooltip" title="{{ _("Short URL") }}"></i>&nbsp;