Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing a caching layer! #188

Merged
merged 3 commits into from
Mar 23, 2016
Merged

Introducing a caching layer! #188

merged 3 commits into from
Mar 23, 2016

Conversation

mistercrunch
Copy link
Member

No description provided.

@mistercrunch mistercrunch force-pushed the caching branch 9 times, most recently from 0f1d649 to e7f599b Compare March 22, 2016 05:31
@mistercrunch mistercrunch changed the title [WiP] Introducing a caching layer Introducing a caching layer! Mar 22, 2016
@mistercrunch
Copy link
Member Author

@michellethomas @williaster, this is up for review, I did all the changes with spoke about

@landscape-bot
Copy link

Code Health
Repository health increased by 6% when pulling e7f599b on caching into 0890d22 on master.

@mistercrunch
Copy link
Member Author

Sorry about clogging this feature with all the linting... Should have been 2 different PRs

@landscape-bot
Copy link

Code Health
Repository health increased by 6% when pulling aadbe36 on caching into 0890d22 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.695% when pulling aadbe36d9776f0d8998f87697ec8dedda583dc24 on caching into 0890d22 on master.

williaster
williaster reviewed Mar 22, 2016
View reviewed changes
dashed/assets/javascripts/dashboard.js
@@ -89,8 +89,8 @@ var Dashboard = function (dashboardData) {
dashboard = this;
var gridster = $(".gridster ul").gridster({
autogrow_cols: true,
widget_margins: [10, 10],
widget_base_dimensions: [100, 100],
widget_margins: [5, 5],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more separation between charts looks significantly better / set it to 10 intentionally. see what @michellethomas thinks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 it is!

@landscape-bot
Copy link

Code Health
Repository health increased by 5% when pulling fded04a on caching into 2d3edf3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.61% when pulling fded04a on caching into 2d3edf3 on master.

@landscape-bot
Copy link

Code Health
Repository health increased by 5% when pulling 417749f on caching into 2d3edf3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.61% when pulling 417749f on caching into 2d3edf3 on master.

@mistercrunch mistercrunch merged commit b0f10a9 into master Mar 23, 2016
@mistercrunch mistercrunch deleted the caching branch March 23, 2016 05:55
@gbrian gbrian mentioned this pull request Mar 30, 2016
Closed
@vylc vylc mentioned this pull request Oct 19, 2018
Closed
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.2 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mistercrunch @landscape-bot @coveralls @williaster