-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing a caching layer! #188
Conversation
0f1d649
to
e7f599b
Compare
@michellethomas @williaster, this is up for review, I did all the changes with spoke about |
|
Sorry about clogging this feature with all the linting... Should have been 2 different PRs |
|
Coverage increased (+0.2%) to 65.695% when pulling aadbe36d9776f0d8998f87697ec8dedda583dc24 on caching into 0890d22 on master. |
@@ -89,8 +89,8 @@ var Dashboard = function (dashboardData) { | |||
dashboard = this; | |||
var gridster = $(".gridster ul").gridster({ | |||
autogrow_cols: true, | |||
widget_margins: [10, 10], | |||
widget_base_dimensions: [100, 100], | |||
widget_margins: [5, 5], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think more separation between charts looks significantly better / set it to 10 intentionally. see what @michellethomas thinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 it is!
|
|
No description provided.