Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data cache #179

Closed
gbrian opened this issue Mar 14, 2016 · 4 comments
Closed

Data cache #179

gbrian opened this issue Mar 14, 2016 · 4 comments

Comments

@gbrian
Copy link
Contributor

gbrian commented Mar 14, 2016

Hi,

I'll need to cache some data to avoid querying DB continuously. Any preferred approach ?
Currently I'm thinking on adding basic caching. It will include an new attribute for the slice- "Time to live", "Cache time" or similar with 0 meaning no cache-. We'll need a way to invalidate cache as well ;)

What about something quite basic using https://pypi.python.org/pypi/pyfscache/ ?
We can use it at class method BaseViz::get_df level, don't you?

Thanks

@mistercrunch
Copy link
Member

I've used flask-cache before, works as a decorator on a web view. Query level might be more targeted.

I'd like for it to be parametrizable at the application / DB / dataset / dashboard / slice level, where it goes up the chain of defaults with the right fallback rule. It needs to support a wide variety of backends (memcache, redis, filesystem, ..,).

The UI should also be upfront about how old the cache is (icon with tooltip, as of 00:03:22 ago)

@gbrian
Copy link
Contributor Author

gbrian commented Mar 14, 2016

Agree,

So a cache wrapper we can extend later with multiple providers, will it do the job?.
What do you mean with "Query level" I was looking for a single point where to apply the cache and I landed at BaseViz::get_df. Maybe do you prefer it to managed per datasource ?

Nice idea about adding the info in a tooltip.

@gbrian
Copy link
Contributor Author

gbrian commented Mar 30, 2016

HI @mistercrunch,
I guess #188 answers this request, right?

@mistercrunch
Copy link
Member

Yeah we're done here :)

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this issue Oct 4, 2021
…pache#179)

Updates the requirements on [fast-glob](https://github.com/mrmlnc/fast-glob) to permit the latest version.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](mrmlnc/fast-glob@2.2.6...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
…pache#179)

Updates the requirements on [fast-glob](https://github.com/mrmlnc/fast-glob) to permit the latest version.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](mrmlnc/fast-glob@2.2.6...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
…pache#179)

Updates the requirements on [fast-glob](https://github.com/mrmlnc/fast-glob) to permit the latest version.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](mrmlnc/fast-glob@2.2.6...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
…pache#179)

Updates the requirements on [fast-glob](https://github.com/mrmlnc/fast-glob) to permit the latest version.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](mrmlnc/fast-glob@2.2.6...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
…pache#179)

Updates the requirements on [fast-glob](https://github.com/mrmlnc/fast-glob) to permit the latest version.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](mrmlnc/fast-glob@2.2.6...3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants