Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a sass-lint configuration file #34

Closed
wants to merge 1 commit into from

Conversation

sminnee
Copy link

@sminnee sminnee commented Sep 17, 2016

This sass-lint configuration file follows the documented styleguide as
best we can with the current sass-lint rules available, and makes some
notes as to other items that could, in principle, be added as automated
rules.

Note that http://sasstools.github.io/make-sass-lint-config/ was used as
the starting point of this, but manual revision was necessary to get a
good result.

To help developers who are retrospectively applying this styleguide,
the rules that would require non-trivial changes (use of id selectors,
class name formats, nesting levels, and variable names) are flagged as
warnings rather than errors.

This sass-lint configuration file follows the documented styleguide as
best we can with the current sass-lint rules available, and makes some
notes as to other items that could, in principle, be added as automated
rules.

Note that http://sasstools.github.io/make-sass-lint-config/ was used as
the starting point of this, but manual revision was necessary to get a
good result.

To help developers who are retrospectively applying this styleguide,
the rules that would require non-trivial changes (use of id selectors,
class name formats, nesting levels, and variable names) are flagged as
warnings rather than errors.
@ljharb
Copy link
Collaborator

ljharb commented Sep 17, 2016

Between this and #23, I think that perhaps we should only add configs if we have a shared way to verify that they match our intentions - like a CSS file they are all run against, or the guide itself.

@sminnee
Copy link
Author

sminnee commented Sep 17, 2016

Good idea - do you have a reference CSS file available?

@ljharb
Copy link
Collaborator

ljharb commented Sep 17, 2016

I don't off hand, but we should probably create one that has a 1:1 correspondence with the written guide.

@ilan-schemoul ilan-schemoul mentioned this pull request Mar 10, 2017
@sminnee
Copy link
Author

sminnee commented Feb 6, 2019

I'm cleaning up my old pull requests; was there any interest in taking this further?

@sminnee sminnee closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants