add support for get currently being displayed data #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihart
reviewed
Oct 14, 2017
| * @return The pagedList currently being displayed. | ||
| */ | ||
| public PagedList<T> getPagedList() { | ||
| return this.pagedList == null ? (PagedList<T>) Collections.<T>emptyList() : this.pagedList; |
There was a problem hiding this comment.
You can't just cast the list to a PagedList, that will crash. I think we need to return null in this case, it isn't possible to create our own empty paged list
There was a problem hiding this comment.
Yes, null check here is unnecessary.
elihart
reviewed
Oct 14, 2017
| @@ -177,6 +177,24 @@ public void setList(@Nullable PagedList<T> list) { | |||
| updatePagedListSnapshot(); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the list currently being displayed by the EpoxyController. | |||
There was a problem hiding this comment.
can you note that this is either a snapshot of the paged list or the list set with setList?
There was a problem hiding this comment.
Oh! you are right, this is inaccurate
| * @return The list currently being displayed. | ||
| */ | ||
| public List<T> getCurrentList() { | ||
| return this.list == null ? Collections.<T>emptyList() : this.list; |
There was a problem hiding this comment.
list is never null, you can return it directly
There was a problem hiding this comment.
Null check here is unnecessary too.
|
It's my negligence, I've update the code. Sorry for reply until 2 days later. |
sorry for this again
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also: #314 .
with two methods: