Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ID generation methods to new public IdUtils class #724

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Extract ID generation methods to new public IdUtils class #724

merged 1 commit into from
Apr 10, 2019

Conversation

chrisbanes
Copy link
Contributor

Closes #723

@elihart
Copy link
Contributor

elihart commented Apr 9, 2019

Thanks for doing this. looks great to me, there are just some style violations

[ant:checkstyle] [ERROR] /home/travis/build/airbnb/epoxy/epoxy-adapter/src/main/java/com/airbnb/epoxy/IdUtils.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/travis/build/airbnb/epoxy/epoxy-adapter/src/main/java/com/airbnb/epoxy/IdUtils.java:9:22: '{' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/travis/build/airbnb/epoxy/epoxy-adapter/src/main/java/com/airbnb/epoxy/IdUtils.java:9:22: '}' is not preceded with whitespace. [WhitespaceAround]

@chrisbanes
Copy link
Contributor Author

🤞 checkstyle is now happy

@elihart elihart merged commit 688bddb into airbnb:master Apr 10, 2019
@elihart
Copy link
Contributor

elihart commented Apr 10, 2019

Thanks a bunch!

@chrisbanes chrisbanes deleted the idutils branch April 10, 2019 02:16
@elihart elihart mentioned this pull request Apr 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbanes @elihart