This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Allow a logger instance to be injected via the configuration #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
allow-logger-to-be-fully-injected
branch
from
a9c3e32
to
d7e40ff
Compare
|
@goatslacker PTAL |
goatslacker
approved these changes
Feb 15, 2018
|
Can you please rebase? |
schleyfox
force-pushed
the
allow-logger-to-be-fully-injected
branch
from
d7e40ff
to
8195b98
Compare
Currently, config can specify the options to be passed to the constructed winston logger, but the specific transport is hard coded as Console. Some applications may wish to use other transports like Syslog that are defined in other packages. This change adds a config field, `loggerInstance`, that allows an arbitrarily constructed logger to be passed in. Really any object that implements `log` should work, but this is intended for other winston loggers.
schleyfox
force-pushed
the
allow-logger-to-be-fully-injected
branch
from
8195b98
to
61611de
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, config can specify the options to be passed to the
constructed winston logger, but the specific transport is hard coded as
Console. Some applications may wish to use other transports like Syslog
that are defined in other packages.
This change adds a config field,
loggerInstance, that allows anarbitrarily constructed logger to be passed in. Really any object that
implements
logshould work, but this is intended for other winstonloggers.
/cc @goatslacker