[guide] Fix description of rule 23.8 to specify export-default
#2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the description of rule 23.8 to specify naming files in "PascalCase when you export-**default** a constructor", not when you merely export a constructor (i.e., among multiple exports).
ljharb
requested changes
May 1, 2019
| @@ -3308,7 +3308,7 @@ Other Style Guides | |||
| ``` | |||
|
|
|||
| <a name="naming--PascalCase-singleton"></a><a name="22.8"></a> | |||
| - [23.8](#naming--PascalCase-singleton) Use PascalCase when you export a constructor / class / singleton / function library / bare object. | |||
| - [23.8](#naming--PascalCase-singleton) Use PascalCase when you export-default a constructor / class / singleton / function library / bare object. | |||
There was a problem hiding this comment.
This is an incorrect change; PascalCase always applies to these cases, whether named or default exported.
There was a problem hiding this comment.
Pardon me! I thought this rule was referring to naming the file when you export-default a class. The two rules immediately before refer to naming the file in such cases, and the example uses export-default. My mistake!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the description of rule 23.8 to specify naming files in "PascalCase when you export-default a constructor", not when you merely export a constructor (i.e., among multiple exports).