Configure Travis tests for Python versions #456
Conversation
naoyak
changed the title
|
✅ Build knowledge-repo 1.0.528 completed (commit 41ecea1feb by @naoyak) |
|
✅ Build knowledge-repo 1.0.529 completed (commit cfb7083d61 by @naoyak) |
naoyak
changed the title
|
✅ Build knowledge-repo 1.0.530 completed (commit b2e760018c by @naoyak) |
|
✅ Build knowledge-repo 1.0.531 completed (commit 0352218743 by @naoyak) |
| @@ -3,7 +3,7 @@ | |||
| # This file is only needed for setting up a dedicated server configuration | |||
| # with support for extracting username information and emailing users. | |||
|
|
|||
| SERVER_NAME = 'localhost' | |||
| SERVER_NAME = 'localhost.localdomain' | |||
There was a problem hiding this comment.
Why this change? I think this will lead to platform specific behaviour, no?
There was a problem hiding this comment.
@matthewwardrop so I noticed that the test runs have a bunch of Flask warnings, and this makes them go away. This config is only for running the test suite, right?
There was a problem hiding this comment.
@naoyak Yep... I was worried it might break Windows... but it didn't! Merging!
|
✅ Build knowledge-repo 1.0.532 completed (commit 8e92184984 by @naoyak) |
Description of changeset:
Travis scripts were not actually using the Python versions specified in the build matrix (
condawas installing 3.7 for the Python 3 build).Test Plan:
Run CI
Auto-reviewers: @NiharikaRay @matthewwardrop @earthmancash @danfrankj