Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Travis tests for Python versions #456

Merged
merged 5 commits into from
Oct 3, 2018
Merged

Configure Travis tests for Python versions #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eabd1fe
config Flask SERVER_NAME to get rid of UserWarning
naoyak Sep 27, 2018
28861f1
configure Python version in CI
naoyak Sep 27, 2018
9bebc10
add 3.5
naoyak Sep 27, 2018
1270575
appveyor
naoyak Sep 27, 2018
e4aece4
3.6 on appveyor
naoyak Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ language: python
python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"

before_install:
# We do this conditionally because it saves us some downloading if the
Expand All @@ -18,8 +20,9 @@ before_install:
# Useful for debugging any issues with conda
- conda info -a
# Replace dep1 dep2 ... with your dependencies
- conda install -c r r
- conda install -c r r-knitr
- conda create -n testenv python=$TRAVIS_PYTHON_VERSION
- source activate testenv
- conda install -c r r r-knitr
install:
- pip install pycodestyle
- pip install .[all]
Expand Down
9 changes: 4 additions & 5 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ environment:
PYTHON_ARCH: "32"
MINICONDA: C:\Miniconda

- PYTHON: "C:\\Python34"
PYTHON_VERSION: "3.4.1"
PYTHON_ARCH: "32"
- PYTHON: "C:\\Python36-x64"
PYTHON_VERSION: "3.6.6"
PYTHON_ARCH: "64"
MINICONDA: C:\Miniconda3

init:
Expand All @@ -20,8 +20,7 @@ init:
# Useful for debugging any issues with conda
- conda info -a
# Replace dep1 dep2 ... with your dependencies
- conda install -c r r
- conda install -c r r-knitr
- conda install -c r r r-knitr

install:
- "%PYTHON%/Scripts/pip.exe install autopep8 pep8"
Expand Down
2 changes: 1 addition & 1 deletion tests/config_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# This file is only needed for setting up a dedicated server configuration
# with support for extracting username information and emailing users.

SERVER_NAME = 'localhost'
SERVER_NAME = 'localhost.localdomain'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? I think this will lead to platform specific behaviour, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewwardrop so I noticed that the test runs have a bunch of Flask warnings, and this makes them go away. This config is only for running the test suite, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naoyak Yep... I was worried it might break Windows... but it didn't! Merging!


# ---------------------------------------------------
# Database configuration
Expand Down