Fix Potential NPE In NetworkCache.clearCache #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
reviewed
Aug 18, 2023
lottie/src/main/java/com/airbnb/lottie/network/NetworkCache.java
Outdated
Show resolved
Hide resolved
gpeal
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an app that I maintain, a crash was reported in Crashlytics indicating that there was a NPE in the Lottie library code.
It took me a bit to realize why the NPE was being caused by trying to read the length of a null array, but then I realized, the for loop calls
parentDir.listFiles()again to iterate over rather than using thefilesarray that was just checked the line above.The changes are quite minor and should fix the problem of the NPE, that being said there may be other concerns that I'm not aware of.