Fix issue where trim offset could be calculated incorrectly #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichoracek
approved these changes
Apr 27, 2023
Comment on lines
+149
to
+150
| let offsetStart = start.cgFloatValue + (offset.cgFloatValue / 360 * 100) | ||
| let offsetEnd = end.cgFloatValue + (offset.cgFloatValue / 360 * 100) |
There was a problem hiding this comment.
nit: maybe discuss why we have these values we're dividing and multiplying by
|
Thank you! |
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where trim offsets could be calculated incorrectly, causing the animation to be rendered incorrectly. Fixes #1979.
The previous implementation from #1612 predated
Keyframes.combinedso was totally custom, and must have had a bug somewhere. Consolidating this to use the same interpolation code we use elsewhere also fixes some other minor issues in the regression suite where some stroke trims were rendered in a very-slightly different way between the two engines.