Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup processing abstraction to lay the groundwork for KSP #152

Closed
wants to merge 14 commits into from

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Feb 22, 2021

First step for #151

I've copied over the processing abstractions from https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/compiler-processing/ to allow the paris processor to share code between javac and KSP.

I've got the majority of the paris code converted to this abstraction, but some things like dealing with resources and packages are more difficult (and maybe impossible...) so KSP cannot be used quite yet.

All unit and instrumentation tests pass so this should be generally correct, but I will want to try it in our app with our screenshot testing to hopefully identify any small bugs. The code could also use a little clean up before merging still.

@elihart
Copy link
Contributor Author

elihart commented Aug 31, 2021

Closed in favor of #158

@elihart elihart closed this Aug 31, 2021
@elihart elihart deleted the eli-ksp branch April 3, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant