Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to add a DayPickerController component? #524

Closed
tagoro9 opened this issue May 19, 2017 · 4 comments
Closed

Does it make sense to add a DayPickerController component? #524

tagoro9 opened this issue May 19, 2017 · 4 comments
Labels
pull request wanted This is a great way to contribute! Help us out :-D

Comments

@tagoro9
Copy link
Contributor

tagoro9 commented May 19, 2017

We wanted to build a <SingleDatePicker /> component but with a custom input component. We ended up creating a <DayPickerController /> component with a similar purpose than the <DayPickerRangeController />. Most of the logic of our component is really similar to the one inside <SingleDatePicker/>. The update to 0.11.0 involved changing a lot of the mentioned <DayPickerController /> as the modifiers logic changed.

Because of all this, I was wondering if it would make sense to extract some of the logic inside the <SingleDatePicker /> component into the mentioned <DayPickerController /> in order to provide the same flexibility the <DayPickerRangeController/> provides towards building customized date range pickers.

@majapw
Copy link
Collaborator

majapw commented May 19, 2017

Yes omg yes. This has been on my roadmap for like half a year (basically since we separated out the DayPickerRangeController). I have like a half-baked branch for it but haven't really ever gotten around to finish this. This would be HIGHLY appreciated.

@majapw majapw added the pull request wanted This is a great way to contribute! Help us out :-D label May 19, 2017
@tagoro9
Copy link
Contributor Author

tagoro9 commented May 19, 2017

Great! I'll try to create a PR with what we have.

@pokonski
Copy link

That would be great to have as I'm in exact situation like you @tagoro9 👍

@majapw
Copy link
Collaborator

majapw commented Jun 28, 2017

This exists in v12.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request wanted This is a great way to contribute! Help us out :-D
Projects
None yet
Development

No branches or pull requests

3 participants