Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tf] Change alerts_bucket type to string in tf_rule_promotion_iam module #1199

Merged
merged 1 commit into from
Mar 18, 2020
Merged

[tf] Change alerts_bucket type to string in tf_rule_promotion_iam module #1199

merged 1 commit into from
Mar 18, 2020

Conversation

chunyong-lin
Copy link
Contributor

to: @airbnb/streamalert-maintainers
related to:
resolves:

Background

Minor fix that the type of alerts_bucket in tf_rule_promotion_iam module should be a string.

Testing

Ran terraform validate internally and it was passed.

@chunyong-lin chunyong-lin added this to the 3.1.0 milestone Mar 18, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.424% when pulling a28c11a on cylin_fix_tf_rule_promotion_iam into c181be1 on release-3-1-0.

@chunyong-lin chunyong-lin merged commit 8edeab6 into release-3-1-0 Mar 18, 2020
@chunyong-lin chunyong-lin deleted the cylin_fix_tf_rule_promotion_iam branch March 18, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryxias Ryxias Ryxias approved these changes

Assignees
No one assigned
Labels
bug terraform
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chunyong-lin @coveralls @Ryxias