Missing alerts table creation during init

[chunyong-lin]

to: @airbnb/streamalert-maintainers
related to: #1163
resolves:

Background

In #1163, we had additional check on if firehose module (for logs) enable or not before creating the alerts table. By default, the firehose module is disabled and alerts table won't be created during the init time. The alerts table is not depend on firehose module (for logs). The fix is easy, move the "firehose_data_bucket" check after "alerts" table creation.

Changes

• Move the "firehose_data_bucket" check after "alerts" table creation.
• Change logging severity to warning if firehose module is disabled in conf/global.json.
• Correct a typo in the logging message.

Testing

Tested in staging and the alerts table is created as expected when firehose module remaining disable.

[coveralls]

Coverage remained the same at 95.424% when pulling 7b4411e on missing_alerts_table_creation_during_init into 530a154 on release-3-1-0.