Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce class attr BaseViz.enforce_numerical_metrics #5176

Merged
merged 1 commit into from Jun 14, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jun 11, 2018

@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #5176 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5176      +/-   ##
==========================================
+ Coverage   77.46%   77.47%   +<.01%     
==========================================
  Files          44       44              
  Lines        8729     8732       +3     
==========================================
+ Hits         6762     6765       +3     
  Misses       1967     1967
Impacted Files Coverage Δ
superset/viz.py 81.33% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3477ab...c3501b2. Read the comment docs.

Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm This seems like a good solution to me. Ideally we'd be getting the correct types in pandas and wouldn't need to coerce to num at all, but when I looked around I didn't find a great solution to this problem.

When were you seeing the incorrect object types (what are the steps to reproduce)? Just for future reference it would be nice to better understand the problem.

@michellethomas
Copy link
Contributor

@mistercrunch this lgtm, merge?

@mistercrunch
Copy link
Member Author

Related unmerged PR here:
#4724

@mistercrunch mistercrunch merged commit a109543 into apache:master Jun 14, 2018
@mistercrunch mistercrunch deleted the df_metrics_to_num branch June 14, 2018 05:45
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Jun 14, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants