Add rule to prefer weak captures over unowned captures #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a new rule to prefer using
weak
captures overunowned
captures.Reasoning
unowned
captures are unsafe because they will cause the application to crash if the referenced object has been deallocated.weak
captures are safer because they require the author to explicitly consider and handle the case where the referenced object no longer exists.Please react with 👍/👎 if you agree or disagree with this proposal.