-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Etcd service watcher #58
base: master
Are you sure you want to change the base?
Conversation
lib/synapse/service_watcher/etcd.rb
Outdated
|
||
require 'etcd' | ||
|
||
# Monkeypatch till 91f9e72d6d57ae3760e9266835f404d986072590 gets to rubygems.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.2.4 was just released and is available in Ruby Gems - so this could probably be cleaned up.
@bobtfish mind rebasing this to merge cleanly with master? |
276fceb
to
3988e57
Compare
Is this likely to merged soon? The nerve part already seems to be merged? etcd does seem like a better choice (nicer cli tools,and less of a total collapse if quorum is lost). |
any progress on this? |
AFAIK this is good to merge, and it's waiting on someone from airbnb to actually merge it, rather than me to do anything to make it mergeable. (If not, I've missed something - please point it out?) |
@bobtfish Cheers. Hope this will be merged soon. |
I’m guessed that there is some somehow bad data that’s crashing things - if you can show me what it is, I’ll fix and add a test :) Cheers |
For what it is worth, I've done some additional work on the etcd watcher, https://github.com/we7/synapse On 19 November 2014 11:59, Tomas Doran notifications@github.com wrote:
Tristan Colgate-McFarlane"You can get all your daily vitamins from 52 pints of guiness, and a |
Thanks Tom. Yes, I wasn't using Nerve to populate host information in Etcd so the key values didn't match up with what the Etcd watcher on synapse was looking for. I am trying to switch over to using Nerve but etcd support doesn't seem to be a part of the current Gem version and doing a gem install_specific against the github repo doesn't work either. Do we know when the etcd functionality for Nerve will be stable? |
Hi Tom, Here is my etcd key layout: curl http://192.168.183.171:4001/v2/keys/service {"action":"get","node":{"key":"/service","dir":true,"nodes":[{"key":"/service/192.168.186.158:49234","value":"running","expiration":"2014-11-22T21:17:37.738052203Z","ttl":18,"modifiedIndex":73811,"createdIndex":73811},{"key":"/service/192.168.186.158:49235","value":"running","expiration":"2014-11-22T21:17:38.321944617Z","ttl":18,"modifiedIndex":73812,"createdIndex":73812},{"key":"/service/192.168.186.158:49231","value":"running","expiration":"2014-11-22T21:17:36.733670014Z","ttl":17,"modifiedIndex":73809,"createdIndex":73809},{"key":"/service/192.168.186.158:49233","value":"running","expiration":"2014-11-22T21:17:36.878094294Z","ttl":17,"modifiedIndex":73810,"createdIndex":73810},{"key":"/service/192.168.186.158:49232","value":"running","expiration":"2014-11-22T21:17:36.517818371Z","ttl":17,"modifiedIndex":73808,"createdIndex":73808}],"modifiedIndex":3 |
@igor47 Any change this is merged with master? |
status? |
Well this has merge conflicts, so at a minimum needs to be rebased before it is merged. |
8941208
to
15bfb29
Compare
Any update on this? |
I've dropped my version of this PR. We've migrated to consul. On 19 February 2015 at 08:35, Piotr Gasiorowski notifications@github.com
Tristan Colgate-McFarlane"You can get all your daily vitamins from 52 pints of guiness, and a |
Sorry folks, the project maintainer @igor47 is really busy with other projects for Airbnb these days. We're doing our best to find time to respond to pull requests, and we're sorry contributors are waiting so long. Please bear with us in the meantime. |
+1 |
@bobtfish can you get a clean diff together and I can review/merge it? |
af844e4
to
bff24d2
Compare
bff24d2
to
5fc104f
Compare
…the hosts until a reachable host is found.
…tions made to etcd.
|
||
require 'etcd' | ||
|
||
module Synapse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be class Synapse::ServiceWatcher
Also can you add this watcher to the auto creation test?
@bobtfish ping? |
Looks like the v3 etcd API may have solved some of the fundamental issues. I'll take another look at this in the next few days. |
@jolynch if you have any problems/questions feel free to ping https://groups.google.com/forum/#!forum/etcd-dev or @heyitsanthony |
And the etcd watcher part to go with the reporter :)