Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc plugin appears to not work after v0.1.22 #146

Closed
sawyerh opened this issue Oct 17, 2021 · 4 comments
Closed

JSDoc plugin appears to not work after v0.1.22 #146

sawyerh opened this issue Oct 17, 2021 · 4 comments

Comments

@sawyerh
Copy link
Contributor

sawyerh commented Oct 17, 2021

Hi, after upgrading from ts-migrate v0.1.22 to v0.1.25-v0.1.26, the jsdoc plugin no longer runs on the expected files.

Here is a repo showing a simplified example.

Given a repo like the above, v0.1.22 would migrate the JSDoc comments in src/js-doc-example.ts when I ran:

ts-migrate migrate . --plugin jsdoc
TypeScript version: 4.2.4
Initialized tsserver project in 160ms.
Start...
[jsdoc] Plugin 1 of 1. Start...
[jsdoc] Finished in 4ms.
Finished in 4ms, for 1 plugin(s).
Writing 1 updated file(s)...
Wrote 1 updated file(s) in 2ms.

However, with v0.1.26, no files are processed:

TypeScript version: 4.4.4
Initialized tsserver project in 162ms.
Start...
[jsdoc] Plugin 1 of 1. Start...
[jsdoc] Finished in 1ms.
Finished in 2ms, for 1 plugin(s).
Writing 0 updated file(s)...
Wrote 0 updated file(s) in 1ms.
@sandinmyjoints
Copy link

Looking at v0.1.22...v0.1.25, I see that 25dbf58 made changes to the jsdoc plugin. The diff is quite big, and the commit messages is just "fixes", so it's hard to know what's going on there.

@sandinmyjoints
Copy link

(FWIW, npx ts-migrate@0.1.22 migrate . --sources="whatever/*.ts" --plugin jsdoc works.)

@kotmatpockuh
Copy link

is it still working @sandinmyjoints ?
tried - but no luck

@kotmatpockuh
Copy link

@brieb @Rudeg @jjjjhhhhhh @elliotsa @lencioni
any updates on 🔝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants