test(xychart): add AreaStack tests #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Jan 26, 2021
| @@ -66,7 +66,11 @@ export default function BaseAxis<Scale extends AxisScale>({ | |||
| ? (width ?? 0) - (margin?.right ?? 0) | |||
| : 0; | |||
|
|
|||
| return ( | |||
| const scale = (orientation === 'left' || orientation === 'right' ? yScale : xScale) as | |||
There was a problem hiding this comment.
Would this look cleaner?
const scale: Scale | undefined = ...
There was a problem hiding this comment.
Definitely ideal, but the type won't work without a coercion either here, or when I get the scales from DataContext (I haven't successfully figured out how to use generics with Context types; most Series coerce the Context values right now)
2 tasks
williaster
added a commit
that referenced
this pull request
Jan 26, 2021
* fix(xychart/BaseAxis): handle undefined scale * fix(xychart/useDimensions): fix partial initialDimensions * new(xychart/useScales): avoid NaN domain when no values are present * fix(xychart/DataProvider): no negative ranges or dimensions * fix(xychart/getScaleBandwidth): handle undefined scale case * test(xychart): add AreaStack, useStackedData tests
williaster
added a commit
that referenced
this pull request
Jan 26, 2021
* new(xychart): mid AreaStack addition * new(xychart/useStackedData): improve logic for all stack offsets * new(xychart): add working polished AreaStack, AnimatedAreaStack * lint(xychart/private/BaseAreaStack) * fix(demo/xychart): fix BaseAreaStack import * fix(xychart/stack): fix component names + comment copy * test(xychart): add AreaStack tests (#1036) * fix(xychart/BaseAxis): handle undefined scale * fix(xychart/useDimensions): fix partial initialDimensions * new(xychart/useScales): avoid NaN domain when no values are present * fix(xychart/DataProvider): no negative ranges or dimensions * fix(xychart/getScaleBandwidth): handle undefined scale case * test(xychart): add AreaStack, useStackedData tests * test(xychart): fix tests to handle undefined scales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This adds tests for
useStackedDataandAreaStackadded in #1019🐛 Bug Fix
In the process of adding tests I fixed two
DataProviderissues which can result in invalid scales on initial render:useDimensionscould result inwidth,height, ormarginbeingundefinedupon initialization, resulting in invalidscale.ranged3scales initialized withdomain: []result indomain = [NaN, NaN], which previously could happen when no data was present in the data registry (now we deferscaleinitialization until data is present)@kristw @hshoff