Add initialHeight and initialWidth to withParentSize

[shannonrothe]

🚀 Enhancements

Adds the ability to set initialWidth/initialHeight to @visx/responsives withParentSize. Closes #554.

[coveralls]

Pull Request Test Coverage Report for Build 77

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 55.296%

---

Totals
Change from base Build 283122090:	0.03%
Covered Lines:	1153
Relevant Lines:	2029

---

💛 - Coveralls

[wyze]

In my opinion, this change should be reverted. It is an anti-pattern as you can see here https://reactjs.org/docs/react-component.html#constructor if you scroll down a little bit to the Note section.

A better solution would be to modify the render function like so:

  render() {
+   const { initialWidth, initialHeight } = this.props;
+   const { parentWidth = initialWidth, parentHeight = initialHeight } = this.state;
-   const { parentWidth, parentHeight } = this.state;
    return (
      <div style={CONTAINER_STYLES} ref={this.setRef}>

[williaster]

thanks for the PR @shannonrothe!

I'm okay with this implementation or @wyze 's suggestion. The react docs highlight that it's an anti-pattern if you are expecting state to update when props change and you get into a mess with componenDidUpdate, but here the naming of the props with initialXXX makes is clear that's not the expectation.

Let me know which you prefer and we can merge this puppy 🚀 .

[shannonrothe]

thanks for the PR @shannonrothe!

I'm okay with this implementation or @wyze 's suggestion. The react docs highlight that it's an anti-pattern if you are expecting state to update when props change and you get into a mess with componenDidUpdate, but here the naming of the props with initialXXX makes is clear that's not the expectation.

Let me know which you prefer and we can merge this puppy 🚀 .

Yeah I thought it would be implied that those values wouldn't update but I think @wyze's suggestion is a little nicer. I've fixed up so should be ready to merge 👍

[williaster]

Awesome, thanks @shannonrothe!