truncate crash log string to 60000 characters #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
reviewed
Jul 6, 2017
Airbrake/notifier/ABNotifier.m
Outdated
| // chrash reports seems to be limited to 64kb, otherwise they are ignored by the API with the following error | ||
| // [Airbrake] {"code":400,"type":"Bad Request","message":"http: request body too large"} | ||
| // so we truncate the string to 60000 characters | ||
| if(dataStr.length > 60000) { |
There was a problem hiding this comment.
- Our API limit is 64KB, not 60000 characters, hence this is not the most precise check
- Looks like you truncate a string. We need to check dumped JSON if it's bigger than 64KB and then truncate payload in the notice object
|
@kyrylo Thats true this check was not very precise. I now first create the JSON, check the size and if it is too large i truncate the payload string |
|
This looks good to me. My only concern is that the size limit is hardcoded in the API. |
|
@jocelynlih that's a correct assumption. We hardcode this in every notifier that supports this feature. |
|
Thanks, @juergenm! |
|
@kyrylo thanks for merging, could you please release a new version so that I can use it with CocoaPods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix "Request body to large" error. fixes #82