-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using blocklist with "name" filters out notifier name #1301
Labels
Comments
This also means that when we go to the performance monitoring page it tells us our notifier "[Filtered]" is not supported "Request Performance Monitoring for [Filtered]" |
kyrylo
added a commit
that referenced
this issue
Nov 25, 2022
Fixes #1301 (Using blocklist with "name" filters out notifier name) Just like in airbrake-ruby, we must not filter out service information, such as notifier name and version.
kyrylo
added a commit
that referenced
this issue
Nov 25, 2022
Fixes #1301 (Using blocklist with "name" filters out notifier name) Just like in airbrake-ruby, we must not filter out service information, such as notifier name and version.
I was just looking into this and it does not look like it is fixed... notice how "name" is still listed as "[Filtered]" in structure that is viewed in airbrake:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 bug report
Affected Package
airbrake-js browser
Is this a regression?
As far as I am aware this has never worked.
Description
When the keysBlocklist contains "name" the notifier name is reported as "[Filtered]"
This is the notifier section when viewed through the airbrake console:
"notifier": {
"name": "[Filtered]",
"url": "https://github.com/airbrake/airbrake-js/tree/master/packages/browser",
"version": "2.1.7"
},
🔬 Minimal Reproduction
🌍 Your Environment
Occurs on 2.1.7 and 1.4.2
The text was updated successfully, but these errors were encountered: