Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using blocklist with "name" filters out notifier name #1301

Closed
gzmarstone opened this issue Nov 7, 2022 · 2 comments · Fixed by #1325
Closed

Using blocklist with "name" filters out notifier name #1301

gzmarstone opened this issue Nov 7, 2022 · 2 comments · Fixed by #1325
Assignees
Labels

Comments

@gzmarstone
Copy link

🐞 bug report

Affected Package

airbrake-js browser

Is this a regression?

As far as I am aware this has never worked.

Description

When the keysBlocklist contains "name" the notifier name is reported as "[Filtered]"

This is the notifier section when viewed through the airbrake console:
"notifier": {
"name": "[Filtered]",
"url": "https://github.com/airbrake/airbrake-js/tree/master/packages/browser",
"version": "2.1.7"
},

🔬 Minimal Reproduction


export const KEYS_BLOCKLIST = [
  'name'
];
    this.airbrake = new Notifier({
      projectId: AIRBRAKE_PROJECT_ID,
      projectKey: AIRBRAKE_PROJECT_KEY,
      environment:
        environmentService.environmentName === EnvironmentName.Prod ? 'production' : environmentService.environmentName,
      keysBlocklist: KEYS_BLOCKLIST
    });

🌍 Your Environment

Occurs on 2.1.7 and 1.4.2

@gzmarstone gzmarstone added the bug label Nov 7, 2022
@gzmarstone
Copy link
Author

This also means that when we go to the performance monitoring page it tells us our notifier "[Filtered]" is not supported "Request Performance Monitoring for [Filtered]"

@kyrylo kyrylo self-assigned this Nov 15, 2022
kyrylo added a commit that referenced this issue Nov 25, 2022
Fixes #1301
(Using blocklist with "name" filters out notifier name)

Just like in airbrake-ruby, we must not filter out service information, such as
notifier name and version.
kyrylo added a commit that referenced this issue Nov 25, 2022
Fixes #1301
(Using blocklist with "name" filters out notifier name)

Just like in airbrake-ruby, we must not filter out service information, such as
notifier name and version.
@gzmarstone
Copy link
Author

gzmarstone commented Apr 27, 2023

I was just looking into this and it does not look like it is fixed... notice how "name" is still listed as "[Filtered]" in structure that is viewed in airbrake:

{
  "client": "WWWWWW",
  "error": {
    "message": "Service Unavailable"
  },
  "headers": {
    "lazyUpdate": null,
    "normalizedNames": {
      "__type": "Map"
    }
  },
  "kind": "Http",
  "message": "HttpException: Error: Http failure response for https://xxxxxxxxxxxxxxx/yy/zzzzzzzzzzz: 503 OK: Service Unavailable",
  "name": "[Filtered]",
  "noStack": true,
  "ok": false,
  "request": {
    "body": null,
    "context": {
      "map": {
        "__type": "Map"
      }
    },
    "headers": {
      "headers": {
        "__type": "Map"
      },
      "lazyInit": null,
      "lazyUpdate": null,
      "normalizedNames": {
        "__type": "Map"
      }
    },
    "method": "GET",
    "params": {
      "cloneFrom": null,
      "encoder": {},
      "map": {
        "__type": "Map"
      },
      "updates": null
    },
    "reportProgress": false,
    "responseType": "json",
    "url": "yy/zzzzzzzzzz",
    "urlWithParams": "yy/zzzzzzzzzz",
    "withCredentials": true
  },
  "severity": null,
  "status": 503,
  "statusText": "OK",
  "url": "https://xxxxxxxxxxxxxx/yy/zzzzzzzzzz"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants