Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing heroku rails generator #169

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 0 additions & 94 deletions generators/airbrake/airbrake_generator.rb

This file was deleted.

12 changes: 5 additions & 7 deletions lib/rails/generators/airbrake/airbrake_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def api_key_expression
s = if options[:api_key]
"'#{options[:api_key]}'"
elsif options[:heroku]
"ENV['AIRBRAKE_API_KEY']"
heroku_api_key
end
end

Expand All @@ -67,7 +67,7 @@ def determine_api_key
exit 1
else
puts "... Done."
puts "Heroku's Airbrake API Key is '#{ENV['AIRBRAKE_API_KEY']}'"
puts "Heroku's Airbrake API Key is #{ENV['AIRBRAKE_API_KEY']}"
end
end

Expand All @@ -77,21 +77,19 @@ def heroku_var(var,app_name = nil)
end

def heroku_api_key
heroku_var("AIRBRAKE_API_KEY",options[:app]).split.find {|x| x unless x.blank?}
"'#{`heroku config:get AIRBRAKE_API_KEY`.gsub("\n","")}'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask heroku what the api key is
parse the newline out of the result

end

def heroku?
options[:heroku] ||
system("grep AIRBRAKE_API_KEY config/initializers/airbrake.rb") ||
system("grep AIRBRAKE_API_KEY config/environment.rb")
options[:heroku] || heroku_api_key.length == 32
end

def api_key_configured?
File.exists?('config/initializers/airbrake.rb')
end

def test_airbrake
puts run("rake airbrake:test")
puts run("airbrake raise")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provides cleaner output, ty @shime for making airbrake raise

end

def plugin_is_present?
Expand Down