Keep passed exception if original_exception is nil #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please - I spent ages tracking this down only to find that rykov beat me to it. |
|
+1 this would be a helpful fix |
|
@rykov awesome fix 👍 |
shifi
added a commit
that referenced
this pull request
Jul 28, 2014
Keep passed exception if original_exception is nil
|
🍻 |
|
When will it be released? Thanks! |
|
@mfernandez10pines we are planning to release the new gem version next week. Thank you for your patience. |
|
Awesome!. Thanks for your effort 👍 |
floehopper
added a commit
to alphagov/asset-manager
that referenced
this pull request
Aug 15, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:
bundle update --conservative airbrake
My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.
* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`
Closes #122.
[1]: airbrake/airbrake#271
floehopper
added a commit
to alphagov/asset-manager
that referenced
this pull request
Aug 15, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:
bundle update --conservative airbrake
My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.
* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`
Closes #122.
[1]: airbrake/airbrake#271
floehopper
added a commit
to alphagov/asset-manager
that referenced
this pull request
Aug 17, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:
bundle update --conservative airbrake
My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.
* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`
Closes #122.
[1]: airbrake/airbrake#271
floehopper
added a commit
to alphagov/asset-manager
that referenced
this pull request
Aug 17, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:
bundle update --conservative airbrake
My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.
* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`
Closes #122.
[1]: airbrake/airbrake#271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails, when
ActionController::BadRequestexception is raised, the exception object responds tooriginal_exception, but that method returns a nil value. This causeserror_classand many other values for the Notice to be nil.This change keeps the passed exception, if the exception responds to
original_exceptionorcontinued_exception, but the method call returns nil