Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Airbrake Gem #122

Closed
chrisroos opened this issue Aug 9, 2017 · 0 comments · Fixed by #131
Closed

Upgrade Airbrake Gem #122

chrisroos opened this issue Aug 9, 2017 · 0 comments · Fixed by #131
Assignees

Comments

@chrisroos
Copy link
Contributor

We're using version 4.0.0 of the Airbrake Gem. This version doesn't report on ActionController::BadRequest exceptions correctly. They're reported in Errbit as Notifications, which isn't very helpful.

Pull request 271 in the Airbrake project appears to have fixed this problem.

The pull request was updated on Aug 26 2014 with a comment saying that the fix would be released the following week. Airbrake version 4.1.0 was released on Sep 4 2014 so I suspect we'll want at least this version.

Note that I've copied the text of this description from alphagov/smart-answers#1681 where we encountered the same problem.

@floehopper floehopper self-assigned this Aug 15, 2017
floehopper added a commit that referenced this issue Aug 15, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:

    bundle update --conservative airbrake

My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.

* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`

Closes #122.

[1]: airbrake/airbrake#271
floehopper added a commit that referenced this issue Aug 15, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:

    bundle update --conservative airbrake

My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.

* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`

Closes #122.

[1]: airbrake/airbrake#271
floehopper added a commit that referenced this issue Aug 17, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:

    bundle update --conservative airbrake

My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.

* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`

Closes #122.

[1]: airbrake/airbrake#271
floehopper added a commit that referenced this issue Aug 17, 2017
I changed the constraint in the `Gemfile` from `~> 4.0.0` to `~> 4.0`
and ran the following command:

    bundle update --conservative airbrake

My main motivation for doing this is so that `airbrake` reports
`ActionController::BadRequest` exceptions correctly [1]. However, I've
chosen to upgrade to the latest 4.x version, because that should include
other bug fixes without breaking compatibility with `errbit`. I'm pretty
sure this is safe to do, because I can see that a bunch of other GOV.UK
apps are using this version of `airbrake` in production, e.g.

* `calculators`
* `hmrc-manuals-api`
* `manuals-publisher`
* `publisher`
* `rummager`

Closes #122.

[1]: airbrake/airbrake#271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants