rubocop: fix the Style/ConditionalAssignment cop offesnes #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase |
|
The rest of the PRs will all need a rebase because I'll be merging them one by one and they will be writing to the same file and line. Feel free to review without waiting on rebases. |
|
Good plan. LGTM. |
kyrylo
force-pushed
the
rubocop-style-conditional-assignment
branch
from
15f1f76
to
5023888
Compare
kyrylo
added a commit
that referenced
this pull request
Jan 18, 2016
…nment rubocop: fix the Style/ConditionalAssignment cop offesnes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.