Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec: bump airbrake-ruby to ~> 4.1.0 #915

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Conversation

kyrylo
Copy link
Contributor

@kyrylo kyrylo commented Feb 28, 2019

While upgrading, I noticed some tests are failing. Not sure why, so I decided to give them another though. Using mocks seemed to be a brilliant idea:

  • these tests are faster by order of magnitude
  • we no longer pry into low-level details such as HTTP calls. This layer is
    tested in airbrake-ruby

@kyrylo kyrylo merged commit 1016975 into master Mar 1, 2019
@kyrylo kyrylo deleted the airbrake-ruby-bump branch March 1, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant