rails: load performance hooks only if performance_stats is enabled #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
performance-stats-hooks-fix
branch
from
a5a8e16
to
4b4ed93
Compare
kyrylo
force-pushed
the
performance-stats-hooks-fix
branch
5 times, most recently
from
048cf41
to
577279a
Compare
We load these hooks unnecessarily for those customers who don't use performance stats. It may cause an unwanted overhead for them: we spend CPU time collecting info but never send it. In this commit we check if performance_stats is enabled and include the hooks only if it is.
kyrylo
force-pushed
the
performance-stats-hooks-fix
branch
from
577279a
to
b69c19b
Compare
This was referenced Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We load these hooks unnecessarily for those customers who don't use performance
stats. It may cause an unwanted overhead for them: we spend CPU time collecting
info but never send it. In this commit we check if performance_stats is enabled
and include the hooks only if it is.