GSON upgrade and illegal reflective fix #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we upgrades the GSON dependency to the most current version and mark the
Notice
'sThrowable exception
field astransient
to avoid GSON serialization. Theexception
field isn't used in the notice payload sent to Airbrake and we already extract the type, message, and backtrace from it.This was the error that was reported and seen in our ci specs previous to this fix commit. we no longer see the illegal reflection warning in the latest ci runs of the tests.
Marking the Throwable being serialized as
transient
will cause gson to ignore this field during serialization https://github.com/google/gson/blob/master/UserGuide.md#java-modifier-exclusionBased on what I read about
transient
, it makes sense that GSON ignores the field:closes #34