Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger build workflow for all branches #127

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Nov 29, 2021

With previous syntax, the workflow did not trigger on push on
branches with a slash in its name (e.g. nh/ci_all_branches).

With previous syntax, the workflow did not trigger on push on
branches with a slash in its name (e.g. nh/ci_all_branches).
@galleon
Copy link
Contributor

galleon commented Nov 29, 2021

But this will also trigger build on tags on master which is not desired. One need probably to add - !'v[0-9]+.[0-9]+.[0-9]+'

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

@dbarbier
Copy link
Contributor

But this will also trigger build on tags on master [...]

No

@nhuet
Copy link
Contributor Author

nhuet commented Nov 29, 2021

But this will also trigger build on tags on master which is not desired. One need probably to add - !'v[0-9]+.[0-9]+.[0-9]+'

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

This will not. We had already branches = "*" which triggered on all branches that did not have a "/" in the name, but not on tags.
With branches = "**", it triggers on all branches even if ther is a "/" but still not on tags as the "tags" pattern as not been filled.
Cf https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#onpushpull_requestbranchestags:

If you define only tags or only branches, the workflow won't run for events affecting the undefined Git ref.

@galleon galleon merged commit c8c4c43 into airbus:master Nov 29, 2021
@nhuet nhuet deleted the nh/ci_all_branches branch December 12, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants