Skip to content

Commit

Permalink
Adds jenv's .java-version to project .gitignore (#317)
Browse files Browse the repository at this point in the history
## What

* Makes git ignore [`jenv`](https://www.jenv.be/)'s .`.java-version`
file, to avoid adding it as an unintended artifact in future commits
* As of now, we do not explicitly encourage saving this file, nor do we
require [`jenv`](https://www.jenv.be/) to contribute to the project,
indicating that [`jenv`](https://www.jenv.be/) is the responsibility of
the user, instead of the maintainer(s)

## How

* Adds a rule to the project-level .gitignore file to ignore all
.java-version files

## Recommended reading order
1. Related to the initial steps in
[developing-locally](https://docs.airbyte.com/contributing-to-airbyte/resources/developing-locally)

## Can this PR be safely reverted and rolled back?
<!--
* If you know that your be safely rolled back, check YES.*
* If that is not the case (e.g. a database migration), check NO.
* If unsure, leave it blank.*
-->
- [ x ] YES 💚
- [ ] NO ❌
  • Loading branch information
bengineerdavis committed Apr 1, 2024
1 parent 62c881f commit 7c54196
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ data
**/gmon.out
static_checker_reports/

# ignore jenv artifacts
.java-version

# Logs
acceptance_tests_logs/

Expand Down

0 comments on commit 7c54196

Please sign in to comment.