Source faker: change some fields to be integer (#29213)

* change some fields to be integer * logistics * fix tests? * more fix tests? * fine, breaking change :P * migration doc * metadata * cat config * uh
airbytehq · Aug 9, 2023 · 1f5c16a · 1f5c16a
1 parent b8d5ca7
commit 1f5c16a
Show file tree

Hide file tree

Showing 11 changed files with 40 additions and 33 deletions.
diff --git a/airbyte-integrations/connectors/source-faker/Dockerfile b/airbyte-integrations/connectors/source-faker/Dockerfile
@@ -34,5 +34,5 @@ COPY source_faker ./source_faker
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=4.0.0
+LABEL io.airbyte.version=5.0.0
 LABEL io.airbyte.name=airbyte/source-faker
diff --git a/airbyte-integrations/connectors/source-faker/acceptance-test-config.yml b/airbyte-integrations/connectors/source-faker/acceptance-test-config.yml
@@ -14,7 +14,7 @@ acceptance_tests:
     tests:
       - config_path: secrets/config.json
         backward_compatibility_tests_config:
-          disable_for_version: "2.1.0" # We changed the cursor field of all streams to be "updated_at"
+          disable_for_version: "4.0.0" # We changed the '*_id' and products.year fields to be integers instead of number
   basic_read:
     tests:
       - config_path: secrets/config.json

diff --git a/airbyte-integrations/connectors/source-faker/integration_tests/catalog.json b/airbyte-integrations/connectors/source-faker/integration_tests/catalog.json
@@ -6,7 +6,7 @@
         "$schema": "http://json-schema.org/draft-07/schema#",
         "type": "object",
         "properties": {
-          "id": { "type": "number" },
+          "id": { "type": "integer" },
           "created_at": {
             "type": "string",
             "format": "date-time",

diff --git a/airbyte-integrations/connectors/source-faker/integration_tests/configured_catalog.json b/airbyte-integrations/connectors/source-faker/integration_tests/configured_catalog.json
@@ -7,7 +7,7 @@
           "$schema": "http://json-schema.org/draft-07/schema#",
           "type": "object",
           "properties": {
-            "id": { "type": "number" },
+            "id": { "type": "integer" },
             "created_at": {
               "type": "string",
               "format": "date-time",
@@ -45,9 +45,9 @@
         "name": "purchases",
         "json_schema": {
           "properties": {
-            "id": { "type": "number" },
-            "user_id": { "type": "number" },
-            "product_id": { "type": "number" },
+            "id": { "type": "integer" },
+            "user_id": { "type": "integer" },
+            "product_id": { "type": "integer" },
             "created_at": {
               "type": "string",
               "format": "date-time",
@@ -87,10 +87,10 @@
         "name": "products",
         "json_schema": {
           "properties": {
-            "id": { "type": "number" },
+            "id": { "type": "integer" },
             "make": { "type": "string" },
             "model": { "type": "string" },
-            "year": { "type": "number" },
+            "year": { "type": "integer" },
             "price": { "type": "number" },
             "created_at": {
               "type": "string",

diff --git a/airbyte-integrations/connectors/source-faker/metadata.yaml b/airbyte-integrations/connectors/source-faker/metadata.yaml
@@ -4,7 +4,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: dfd88b22-b603-4c3d-aad7-3701784586b1
-  dockerImageTag: 4.0.0
+  dockerImageTag: 5.0.0
   dockerRepository: airbyte/source-faker
   githubIssueLabel: source-faker
   icon: faker.svg
@@ -32,6 +32,9 @@ data:
     - language:python
   releases:
     breakingChanges:
+      5.0.0:
+        message: "ID and products.year fields are changing to be integers instead of floats."
+        upgradeDeadline: "2023-08-31"
       4.0.0:
         message: "This is a breaking change message"
         upgradeDeadline: "2023-07-19"

diff --git a/airbyte-integrations/connectors/source-faker/source_faker/schemas/products.json b/airbyte-integrations/connectors/source-faker/source_faker/schemas/products.json
@@ -2,10 +2,10 @@
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
   "properties": {
-    "id": { "type": "number" },
+    "id": { "type": "integer" },
     "make": { "type": "string" },
     "model": { "type": "string" },
-    "year": { "type": "number" },
+    "year": { "type": "integer" },
     "price": { "type": "number" },
     "created_at": {
       "type": "string",

diff --git a/airbyte-integrations/connectors/source-faker/source_faker/schemas/purchases.json b/airbyte-integrations/connectors/source-faker/source_faker/schemas/purchases.json
@@ -2,9 +2,9 @@
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
   "properties": {
-    "id": { "type": "number" },
-    "user_id": { "type": "number" },
-    "product_id": { "type": "number" },
+    "id": { "type": "integer" },
+    "user_id": { "type": "integer" },
+    "product_id": { "type": "integer" },
     "created_at": {
       "type": "string",
       "format": "date-time",

diff --git a/airbyte-integrations/connectors/source-faker/source_faker/schemas/users.json b/airbyte-integrations/connectors/source-faker/source_faker/schemas/users.json
@@ -2,7 +2,7 @@
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
   "properties": {
-    "id": { "type": "number" },
+    "id": { "type": "integer" },
     "created_at": {
       "type": "string",
       "format": "date-time",

diff --git a/airbyte-integrations/connectors/source-faker/unit_tests/unit_test.py b/airbyte-integrations/connectors/source-faker/unit_tests/unit_test.py
@@ -9,13 +9,13 @@
 
 
 class MockLogger:
-    def debug(a,b, **kwargs):
+    def debug(a, b, **kwargs):
         return None
 
-    def info(a,b, **kwargs):
+    def info(a, b, **kwargs):
         return None
 
-    def exception(a,b,**kwargs):
+    def exception(a, b, **kwargs):
         print(b)
         return None
 
@@ -46,7 +46,7 @@ def test_source_streams():
 
     assert len(schemas) == 3
     assert schemas[1]["properties"] == {
-        "id": {"type": "number"},
+        "id": {"type": "integer"},
         "created_at": {"type": "string", "format": "date-time", "airbyte_type": "timestamp_with_timezone"},
         "updated_at": {"type": "string", "format": "date-time", "airbyte_type": "timestamp_with_timezone"},
         "name": {"type": "string"},
@@ -62,18 +62,18 @@ def test_source_streams():
         "height": {"type": "string"},
         "blood_type": {"type": "string"},
         "weight": {"type": "integer"},
-        'address': {
-            'type': 'object',
-            'properties': {
-                'city': {'type': 'string'},
-                'country_code': {'type': 'string'},
-                'postal_code': {'type': 'string'},
-                'province': {'type': 'string'},
-                'state': {'type': 'string'},
-                'street_name': {'type': 'string'},
-                'street_number': {'type': 'string'}
-            }
-        }
+        "address": {
+            "type": "object",
+            "properties": {
+                "city": {"type": "string"},
+                "country_code": {"type": "string"},
+                "postal_code": {"type": "string"},
+                "province": {"type": "string"},
+                "state": {"type": "string"},
+                "street_name": {"type": "string"},
+                "street_number": {"type": "string"},
+            },
+        },
     }
 
 

diff --git a/docs/integrations/sources/faker-migrations.md b/docs/integrations/sources/faker-migrations.md
@@ -1,5 +1,8 @@
 # Sample Data (Faker) Migration Guide
 
+## Upgrading to 5.0.0
+Some columns are narrowing from `number` to `integer`. You may need to force normalization to rebuild your destination tables by manually dropping the SCD and final tables, refreshing the connection schema (skipping the reset), and running a sync. Alternatively, you can just run a reset.
+
 ## Upgrading to 4.0.0
 
-Nothing to do here - this was a test breaking change.
+Nothing to do here - this was a test breaking change.
diff --git a/docs/integrations/sources/faker.md b/docs/integrations/sources/faker.md
@@ -96,6 +96,7 @@ None!
 
 | Version | Date       | Pull Request                                                                                                          | Subject                                                                                                         |
 |:--------|:-----------|:----------------------------------------------------------------------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
+| 5.0.0   | 2023-08-08 | [29213](https://github.com/airbytehq/airbyte/pull/29213)                                                              | Change all `*id` fields and `products.year` to be integer                                                       |
 | 4.0.0   | 2023-07-19 | [28485](https://github.com/airbytehq/airbyte/pull/28485)                                                              | Bump to test publication                                                                                        |
 | 3.0.2   | 2023-07-07 | [27807](https://github.com/airbytehq/airbyte/pull/28060)                                                              | Bump to test publication                                                                                        |
 | 3.0.1   | 2023-06-28 | [27807](https://github.com/airbytehq/airbyte/pull/27807)                                                              | Fix bug with purchase stream updated_at                                                                         |