Source faker: change some fields to be integer #29213

edgao · 2023-08-08T15:22:21Z

was slightly confused by ids and year being floats. change them to number.

presumably not a true breaking change since all the data was already integer?

github-actions · 2023-08-08T15:22:44Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-08-08T15:26:25Z

source-faker test report (commit `84ccc76f67`) - ❌

⏲️ Total pipeline duration: 01mn21s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T15:30:09Z

source-faker test report (commit `84ccc76f67`) - ❌

⏲️ Total pipeline duration: 01mn40s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T15:33:04Z

source-faker test report (commit `3a78858712`) - ❌

⏲️ Total pipeline duration: 01mn19s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T15:54:15Z

source-faker test report (commit `2f6081751f`) - ❌

⏲️ Total pipeline duration: 02mn28s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

evantahler · 2023-08-08T15:55:14Z

It's a breaking change ;)
PK changes are scary, so CAT wants us all to watch out.

E       connector_acceptance_test.utils.backward_compatibility.NonBackwardCompatibleError: BackwardIncompatibilityContext.DISCOVER - The'type' field value was changed.. Diff: Value of root['products']['properties']['id']['type'] changed from "number" to "integer".

octavia-squidington-iii · 2023-08-08T23:26:10Z

source-faker test report (commit `e30621cc1e`) - ❌

⏲️ Total pipeline duration: 02mn45s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T23:39:46Z

source-faker test report (commit `843e6f7649`) - ❌

⏲️ Total pipeline duration: 02mn25s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T23:52:20Z

source-faker test report (commit `386045db5b`) - ❌

⏲️ Total pipeline duration: 02mn04s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

octavia-squidington-iii · 2023-08-08T23:59:48Z

source-faker test report (commit `c1e8cf503f`) - ✅

⏲️ Total pipeline duration: 02mn26s

Step	Result
Validate airbyte-integrations/connectors/source-faker/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-faker docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

evantahler · 2023-08-09T00:23:51Z

airbyte-integrations/connectors/source-faker/metadata.yaml

+      5.0.0:
+        message: "ID and products.year fields are changing to be integers instead of floats."
+        upgradeDeadline: "2023-08-31"


cc @erohmensing - a wild breaking change has appeared

I swear I'm not trying to be a conn ops early adopter, it just keeps happening :p

change some fields to be integer

0bb8960

octavia-squidington-iii added area/connectors Connector related issues connectors/source/faker labels Aug 8, 2023

logistics

84ccc76

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 8, 2023

edgao marked this pull request as ready for review August 8, 2023 15:24

edgao requested a review from evantahler August 8, 2023 15:24

fix tests?

3a78858

more fix tests?

2f60817

edgao added 2 commits August 8, 2023 16:19

fine, breaking change :P

78251b3

migration doc

e30621c

edgao added 2 commits August 8, 2023 16:32

metadata

a7b8747

cat config

843e6f7

uh

386045d

Merge branch 'master' into edgao/faker_schema

c1e8cf5

evantahler approved these changes Aug 9, 2023

View reviewed changes

edgao merged commit 1f5c16a into master Aug 9, 2023
26 checks passed

edgao deleted the edgao/faker_schema branch August 9, 2023 00:31

evantahler mentioned this pull request Aug 9, 2023

Update Connector CI to report status to Github Status Checks not comments #29300

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source faker: change some fields to be integer #29213

Source faker: change some fields to be integer #29213

edgao commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited by edgao

Loading

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

evantahler commented Aug 8, 2023 •

edited

Loading

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

octavia-squidington-iii commented Aug 8, 2023

evantahler Aug 9, 2023

edgao Aug 9, 2023

Source faker: change some fields to be integer #29213

Source faker: change some fields to be integer #29213

Conversation

edgao commented Aug 8, 2023 • edited Loading

github-actions bot commented Aug 8, 2023 • edited by edgao Loading

Before Merging a Connector Pull Request

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 84ccc76f67) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 84ccc76f67) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 3a78858712) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 2f6081751f) - ❌

evantahler commented Aug 8, 2023 • edited Loading

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit e30621cc1e) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 843e6f7649) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit 386045db5b) - ❌

octavia-squidington-iii commented Aug 8, 2023

source-faker test report (commit c1e8cf503f) - ✅

evantahler Aug 9, 2023

Choose a reason for hiding this comment

edgao Aug 9, 2023

Choose a reason for hiding this comment

edgao commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited by edgao

Loading

source-faker test report (commit `84ccc76f67`) - ❌

source-faker test report (commit `84ccc76f67`) - ❌

source-faker test report (commit `3a78858712`) - ❌

source-faker test report (commit `2f6081751f`) - ❌

evantahler commented Aug 8, 2023 •

edited

Loading

source-faker test report (commit `e30621cc1e`) - ❌

source-faker test report (commit `843e6f7649`) - ❌

source-faker test report (commit `386045db5b`) - ❌

source-faker test report (commit `c1e8cf503f`) - ✅