Change break to continue (#17015)

* Change break to continue
airbytehq · Sep 22, 2022 · 90ceb1b · 90ceb1b
1 parent abed1ce
commit 90ceb1b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/...src/main/java/io/airbyte/workers/temporal/sync/NormalizationSummaryCheckActivityImpl.java b/...src/main/java/io/airbyte/workers/temporal/sync/NormalizationSummaryCheckActivityImpl.java
@@ -35,7 +35,7 @@ public boolean shouldRunNormalization(final Long jobId, final Long attemptNumber
 
     // if the count of committed records for this attempt is > 0 OR if it is null,
     // then we should run normalization
-    if (numCommittedRecords.get() == null || numCommittedRecords.get() > 0) {
+    if (numCommittedRecords.isEmpty() || numCommittedRecords.get() > 0) {
       return true;
     }
 

diff --git a/airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/SyncWorkflowImpl.java b/airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/SyncWorkflowImpl.java
@@ -77,7 +77,7 @@ public StandardSyncOutput run(final JobRunConfig jobRunConfig,
             }
             if (!shouldRun) {
               LOGGER.info("Skipping normalization because there are no records to normalize.");
-              break;
+              continue;
             }
           }
 

diff --git a/airbyte-workers/src/test/java/io/airbyte/workers/temporal/sync/SyncWorkflowTest.java b/airbyte-workers/src/test/java/io/airbyte/workers/temporal/sync/SyncWorkflowTest.java
@@ -300,7 +300,8 @@ void testSkipNormalization() throws IOException {
     verifyReplication(replicationActivity, syncInput);
     verifyPersistState(persistStateActivity, sync, replicationSuccessOutputNoRecordsCommitted, syncInput.getCatalog());
     verifyNoInteractions(normalizationActivity);
-    verifyNoInteractions(dbtTransformationActivity);
+    verifyDbtTransform(dbtTransformationActivity, syncInput.getResourceRequirements(),
+        operatorDbtInput);
   }
 
   @SuppressWarnings("ResultOfMethodCallIgnored")