Skip to content

Commit

Permalink
allow BaseTypingDedupingTest to be interrupted (#37854)
Browse files Browse the repository at this point in the history
When timing out, the LoggingInterceptor attempts to interrupt the test-executing thread. Unfortunately, the `CompletableFuture.join()` call is non-interruptible, which means we still had tests that were hanging forever. This changes it with `CompletableFuture.get()`, which is interruptible (even though the difference in behavior is not clearly documented. One has to notice that `get()` throws an `InterruptedException` while `join()` doesn't).
  • Loading branch information
stephane-airbyte authored and clnoll committed May 10, 2024
1 parent b8bae13 commit 93ae4bd
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ abstract class BaseTypingDedupingTest {
// TODO Eventually we'll want to somehow extract the state messages while a sync is running,
// to
// verify checkpointing.
destinationOutputFuture.join()
destinationOutputFuture.get()
destination.close()
}

Expand Down

0 comments on commit 93ae4bd

Please sign in to comment.