allow BaseTypingDedupingTest to be interrupted #37854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
gisripa
approved these changes
May 6, 2024
stephane-airbyte
deleted the
stephane/05-06-allow_basetypingdedupingtest_to_be_interrupted
branch
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
When timing out, the LoggingInterceptor attempts to interrupt the test-executing thread. Unfortunately, the `CompletableFuture.join()` call is non-interruptible, which means we still had tests that were hanging forever. This changes it with `CompletableFuture.get()`, which is interruptible (even though the difference in behavior is not clearly documented. One has to notice that `get()` throws an `InterruptedException` while `join()` doesn't).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When timing out, the LoggingInterceptor attempts to interrupt the test-executing thread. Unfortunately, the
CompletableFuture.join()call is non-interruptible, which means we still had tests that were hanging forever. This changes it withCompletableFuture.get(), which is interruptible (even though the difference in behavior is not clearly documented. One has to notice thatget()throws anInterruptedExceptionwhilejoin()doesn't).