fix discovery for freshdesk (#3591)

* fix discovery for freshdesk * bump version && merge * create changelog
airbytehq · May 25, 2021 · 9e20303 · 9e20303
1 parent 374f63f
commit 9e20303
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/...ain/resources/config/STANDARD_SOURCE_DEFINITION/ec4b9503-13cb-48ab-a4ab-6ade4be46567.json b/...ain/resources/config/STANDARD_SOURCE_DEFINITION/ec4b9503-13cb-48ab-a4ab-6ade4be46567.json
@@ -2,7 +2,7 @@
   "sourceDefinitionId": "ec4b9503-13cb-48ab-a4ab-6ade4be46567",
   "name": "Freshdesk",
   "dockerRepository": "airbyte/source-freshdesk",
-  "dockerImageTag": "0.2.2",
+  "dockerImageTag": "0.2.3",
   "documentationUrl": "https://hub.docker.com/r/airbyte/source-freshdesk",
   "icon": "freshdesk.svg"
 }
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -138,7 +138,7 @@
 - sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
   name: Freshdesk
   dockerRepository: airbyte/source-freshdesk
-  dockerImageTag: 0.2.2
+  dockerImageTag: 0.2.3
   documentationUrl: https://hub.docker.com/r/airbyte/source-freshdesk
   icon: freshdesk.svg
 - sourceDefinitionId: 396e4ca3-8a97-4b85-aa4e-c9d8c2d5f992

diff --git a/airbyte-integrations/connectors/source-freshdesk/CHANGELOG.md b/airbyte-integrations/connectors/source-freshdesk/CHANGELOG.md
@@ -0,0 +1,4 @@
+# Changelog
+
+## 0.2.3
+Fix discovery and set default cursor field as "updated_at"
diff --git a/airbyte-integrations/connectors/source-freshdesk/Dockerfile b/airbyte-integrations/connectors/source-freshdesk/Dockerfile
@@ -12,5 +12,5 @@ COPY $CODE_PATH ./$CODE_PATH
 COPY setup.py ./
 RUN pip install .
 
-LABEL io.airbyte.version=0.2.2
+LABEL io.airbyte.version=0.2.3
 LABEL io.airbyte.name=airbyte/source-freshdesk
diff --git a/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/client.py b/airbyte-integrations/connectors/source-freshdesk/source_freshdesk/client.py
@@ -23,8 +23,9 @@
 #
 
 
-from typing import Any, Mapping, Tuple
+from typing import Any, Iterable, Mapping, Tuple
 
+from airbyte_protocol import AirbyteStream
 from base_python import BaseClient
 
 from .api import (
@@ -64,6 +65,14 @@ def __init__(self, domain, api_key, requests_per_minute: int = None):
         }
         super().__init__()
 
+    @property
+    def streams(self) -> Iterable[AirbyteStream]:
+        """List of available streams"""
+        for stream in super().streams:
+            if stream.source_defined_cursor:
+                stream.default_cursor_field = [self._apis[stream.name].state_pk]
+            yield stream
+
     def settings(self):
         url = "settings/helpdesk"
         return self._api.get(url)