Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix discovery for freshdesk #3591

Merged

Conversation

vovavovavovavova
Copy link
Contributor

What

Closes #3249

How

By fixing discovery and setting default cursor field as "updated_at"

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@vovavovavovavova vovavovavovavova removed the request for review from jrhizor May 25, 2021 17:15
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented May 25, 2021

/test connector=source-freshdesk

🕑 source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/875779915
✅ source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/875779915

@vovavovavovavova vovavovavovavova removed the request for review from ChristopheDuong May 25, 2021 17:16
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you bump version and publish?

@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented May 25, 2021

/publish connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/875999955
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/875999955

@sherifnada
Copy link
Contributor

@vovavovavovavova please make sure to update the changelog.md as well

@vovavovavovavova vovavovavovavova merged commit 9e20303 into master May 25, 2021
@vovavovavovavova vovavovavovavova deleted the valdemar/#3249_freshdesk_cur_fields_discovery_fix branch May 25, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Freshdesk: declare cursor fields
3 participants