🐛 Source Delighted: fix Date Since date-format bug in UI (#23909)

airbytehq · Mar 9, 2023 · bf33a5d · bf33a5d
1 parent 42709dc
commit bf33a5d
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 8 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -452,7 +452,7 @@
 - name: Delighted
   sourceDefinitionId: cc88c43f-6f53-4e8a-8c4d-b284baaf9635
   dockerRepository: airbyte/source-delighted
-  dockerImageTag: 0.2.1
+  dockerImageTag: 0.2.2
   documentationUrl: https://docs.airbyte.com/integrations/sources/delighted
   icon: delighted.svg
   sourceType: api

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -3145,7 +3145,7 @@
     supportsNormalization: false
     supportsDBT: false
     supported_destination_sync_modes: []
-- dockerImage: "airbyte/source-delighted:0.2.1"
+- dockerImage: "airbyte/source-delighted:0.2.2"
   spec:
     documentationUrl: "https://docsurl.com"
     connectionSpecification:
@@ -3168,8 +3168,9 @@
           type: "string"
           description: "The date from which you'd like to replicate the data"
           examples:
+          - "2022-05-30T04:50:23Z"
           - "2022-05-30 04:50:23"
-          pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2} ([0-9]{2}:[0-9]{2}:[0-9]{2})?$"
+          pattern: "^\\d{4}-\\d{2}-\\d{2}[T ]\\d{2}:\\d{2}:\\d{2}(\\.\\d+)?Z?$"
           order: 1
           format: "date-time"
     supportsNormalization: false

diff --git a/airbyte-integrations/connectors/source-delighted/Dockerfile b/airbyte-integrations/connectors/source-delighted/Dockerfile
@@ -12,5 +12,5 @@ COPY main.py ./.
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.2.1
+LABEL io.airbyte.version=0.2.2
 LABEL io.airbyte.name=airbyte/source-delighted
diff --git a/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml b/airbyte-integrations/connectors/source-delighted/acceptance-test-config.yml
@@ -6,6 +6,8 @@ acceptance_tests:
   spec:
     tests:
       - spec_path: "source_delighted/spec.json"
+        backward_compatibility_tests_config:
+          disable_for_version: 0.2.1
   connection:
     tests:
       - config_path: "secrets/config.json"

diff --git a/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml b/airbyte-integrations/connectors/source-delighted/source_delighted/manifest.yaml
@@ -24,7 +24,7 @@ definitions:
     datetime_format: "%s"
     cursor_granularity: "PT1S"
     start_datetime:
-      datetime: "{{ config['since'] }}"
+      datetime: "{{ format_datetime(config['since'], '%Y-%m-%d %H:%M:%S') }}"
       datetime_format: "%Y-%m-%d %H:%M:%S"
     end_datetime:
       datetime: "{{ today_utc() }}"

diff --git a/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json b/airbyte-integrations/connectors/source-delighted/source_delighted/spec.json
@@ -18,8 +18,8 @@
         "title": "Date Since",
         "type": "string",
         "description": "The date from which you'd like to replicate the data",
-        "examples": ["2022-05-30 04:50:23"],
-        "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2} ([0-9]{2}:[0-9]{2}:[0-9]{2})?$",
+        "examples": ["2022-05-30T04:50:23Z", "2022-05-30 04:50:23"],
+        "pattern": "^\\d{4}-\\d{2}-\\d{2}[T ]\\d{2}:\\d{2}:\\d{2}(\\.\\d+)?Z?$",
         "order": 1,
         "format": "date-time"
       }

diff --git a/connectors.md b/connectors.md
@@ -57,7 +57,7 @@
 | **DV 360** | <img alt="DV 360 icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/dv360.svg" height="30" height="30"/> | Source | airbyte/source-dv-360:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dv-360) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dv-360) | <small>`1356e1d9-977f-4057-ad4b-65f25329cf61`</small> |
 | **Datadog** | <img alt="Datadog icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/datadog.svg" height="30" height="30"/> | Source | airbyte/source-datadog:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/datadog) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-datadog) | <small>`1cfc30c7-82db-43f4-9fd7-ac1b42312cda`</small> |
 | **Datascope** | <img alt="Datascope icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/datascope.svg" height="30" height="30"/> | Source | airbyte/source-datascope:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/datascope) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-datascope) | <small>`8e1ae2d2-4790-44d3-9d83-75b3fc3940ff`</small> |
-| **Delighted** | <img alt="Delighted icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/delighted.svg" height="30" height="30"/> | Source | airbyte/source-delighted:0.2.1 | beta | [link](https://docs.airbyte.com/integrations/sources/delighted) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-delighted) | <small>`cc88c43f-6f53-4e8a-8c4d-b284baaf9635`</small> |
+| **Delighted** | <img alt="Delighted icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/delighted.svg" height="30" height="30"/> | Source | airbyte/source-delighted:0.2.2 | beta | [link](https://docs.airbyte.com/integrations/sources/delighted) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-delighted) | <small>`cc88c43f-6f53-4e8a-8c4d-b284baaf9635`</small> |
 | **Dixa** | <img alt="Dixa icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/dixa.svg" height="30" height="30"/> | Source | airbyte/source-dixa:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/dixa) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dixa) | <small>`0b5c867e-1b12-4d02-ab74-97b2184ff6d7`</small> |
 | **Dockerhub** | <img alt="Dockerhub icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/dockerhub.svg" height="30" height="30"/> | Source | airbyte/source-dockerhub:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dockerhub) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dockerhub) | <small>`72d405a3-56d8-499f-a571-667c03406e43`</small> |
 | **Dremio** | <img alt="Dremio icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/dremio.svg" height="30" height="30"/> | Source | airbyte/source-dremio:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/dremio) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-dremio) | <small>`d99e9ace-8621-46c2-9144-76ae4751d64b`</small> |

diff --git a/docs/integrations/sources/delighted.md b/docs/integrations/sources/delighted.md
@@ -37,6 +37,7 @@ This Source is capable of syncing the following core Streams:
 
 | Version | Date       | Pull Request                                             | Subject                                                                                              |
 |:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------|
+| 0.2.2   | 2023-03-09 | [23909](https://github.com/airbytehq/airbyte/pull/23909) | Updated the input config pattern to accept both `RFC3339` and `datetime string` formats in UI    |
 | 0.2.1   | 2023-02-14 | [23009](https://github.com/airbytehq/airbyte/pull/23009) |Specified date formatting in specification                                                                |
 | 0.2.0   | 2022-11-22 | [19822](https://github.com/airbytehq/airbyte/pull/19822) | Migrate to Low code + certify to Beta                                                                |
 | 0.1.4   | 2022-06-10 | [13439](https://github.com/airbytehq/airbyte/pull/13439) | Change since parameter input to iso date                                                             |