🐛 Source Delighted: fix Date Since date-format bug in UI

[bazarnov]

What

Resolving: https://github.com/airbytehq/oncall/issues/1623

How

• changed the pattern to catch the RFC3339 format, which UI uses for the date picker
• updated manifest.yaml to convert the input config["since"] from 2 formats (old and new) and convert it to the right format needed for the slices.

🚨 User Impact 🚨

No impact is expected since backward compatibility is supported for this issue.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

[bazarnov]

@airbytehq/connector-extensibility Please check this fix, since with the new Date Picker there are issues with selecting the date in the format of RFC3339 but the connector expects a different input format. This might be a potential P0 in the future for all other connectors. Another use case: what if the date field should be in the format of date not date-time and Date Picker will return date-time?

The thing is that the date picker should be able to return the date in the format connector expects it, to support backward compatibility

@airbytehq/connector-operations The bugs like this should be covered by the CAT.

[bazarnov]

/test connector=connectors/source-delighted

🕑 connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/4375935328
✅ connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/4375935328
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:109: Backward compatibility tests are disabled for version 0.2.1.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 346.08s (0:05:46) ===================

[evantahler]

No impact is expected since backward compatibility is supported for this issue.

Excellent!

Of note, this might be a good place to emit an airbyte control message to update the old format of the config to the new format so we don't need to keep format_datetime() around forever. I'll write up a guide on that process later today!

[bazarnov]

No impact is expected since backward compatibility is supported for this issue.

Excellent!

Of note, this might be a good place to emit an airbyte control message to update the old format of the config to the new format so we don't need to keep format_datetime() around forever. I'll write up a guide on that process later today!

@evantahler please refer to this issue, so we have the context later on, thanks! Awesome!

[bazarnov]

/publish connector=connectors/source-delighted

🕑 Publishing the following connectors:
connectors/source-delighted
https://github.com/airbytehq/airbyte/actions/runs/4377298690

Connector	Did it publish?	Were definitions generated?
connectors/source-delighted	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️