Skip to content

Commit

Permalink
airbyte-lib: Prepare for published connectors (#34651)
Browse files Browse the repository at this point in the history
  • Loading branch information
Joe Reuter committed Jan 30, 2024
1 parent d74471e commit dc78238
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions airbyte-lib/airbyte_lib/_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,7 @@ def __init__(

# This is a temporary install path that will be replaced with a proper package
# name once they are published.
# TODO: Replace with `f"airbyte-{self.name}"`
self.pip_url = pip_url or f"../airbyte-integrations/connectors/{self.name}"
self.pip_url = pip_url or f"airbyte-{self.name}"
self.install_root = install_root or Path.cwd()

def _get_venv_name(self) -> str:
Expand Down Expand Up @@ -239,11 +238,12 @@ def _get_installed_version(
return None

try:
package_name = f"airbyte-{connector_name}"
return subprocess.check_output(
[
self.interpreter_path,
"-c",
f"from importlib.metadata import version; print(version('{connector_name}'))",
f"from importlib.metadata import version; print(version('{package_name}'))",
],
universal_newlines=True,
).strip()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
#


from setuptools import find_packages, setup
from setuptools import setup

setup(
name="source_broken",
name="airbyte-source-broken",
version="0.0.1",
description="Test Soutce",
author="Airbyte",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
#


from setuptools import find_packages, setup
from setuptools import setup

setup(
name="source_test",
name="airbyte-source-test",
version="0.0.1",
description="Test Soutce",
author="Airbyte",
Expand Down

0 comments on commit dc78238

Please sign in to comment.